ESP Easy Github pull requests
Moderators: grovkillen, Stuntteam, TD-er
ESP Easy Github pull requests
As we are in the middle of launching a new stable to replace R120, no pull requests will be accepted in the current ESP Easy repository unless they fix a bug.
(and missing features are not considered bugs).
And after the new stable has been released, chances are high that a new repository will be created for future development and the existing repository will remain only for bugfixes on 512k ESP modules.
So please do not create more pull requests on this repository for new features and such.
(and missing features are not considered bugs).
And after the new stable has been released, chances are high that a new repository will be created for future development and the existing repository will remain only for bugfixes on 512k ESP modules.
So please do not create more pull requests on this repository for new features and such.
-
- Normal user
- Posts: 51
- Joined: 09 Jun 2016, 12:37
Re: ESP Easy Github pull requests
Sorry. Hadn't seen this message. Do you want me to remove my pull request?
Edit: I already closed it. I will deliver a new one.
Edit: I already closed it. I will deliver a new one.
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
Wouldn't it be better to just create a 512k branch after the release, and continue development on master as usual?
That way the pullrequests could stay.
A new repository sounds like overkill.
That way the pullrequests could stay.
A new repository sounds like overkill.
-
- Normal user
- Posts: 120
- Joined: 15 Dec 2015, 14:07
Re: ESP Easy Github pull requests
I don't use the 512K's anymore, so have a go 

Located in Belgium, Bruges. Working on a full DIY domoticz setup with ESPEasy.
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
What if we create a easy way to enable/disable certain plugins at compile time?
This way its easy to release different binaries: A "normal" version and a stripped-down 512K version that only has a subsection of plugins enabled by default.
The end-users of the 512k version then can also choose to compile their own version with a different set of plugins enabled.
Edwin
This way its easy to release different binaries: A "normal" version and a stripped-down 512K version that only has a subsection of plugins enabled by default.
The end-users of the 512k version then can also choose to compile their own version with a different set of plugins enabled.
Edwin
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
Now that i think of it: This way we also could handle plugins that are still in "testing" in the playground.
Then we can even release 3 versions: "slim 512k version", "normal" and "normal + all the testing plugins".
Perhaps we cant do that for some special plugins that affect stable code when they are not running. (or plugins that depend on unstable code thats not in mainline yet)
Edwin
Then we can even release 3 versions: "slim 512k version", "normal" and "normal + all the testing plugins".
Perhaps we cant do that for some special plugins that affect stable code when they are not running. (or plugins that depend on unstable code thats not in mainline yet)
Edwin
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
All these things and more are fixed in https://github.com/psy0rz/ESPEasy-platformio (also binary releases over there)
Edwin
Edwin
-
- Core team member
- Posts: 9922
- Joined: 01 Sep 2017, 22:13
- Location: the Netherlands
Re: ESP Easy Github pull requests
What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.
So perhaps someone can shed some light on the status of pull requests to n00bs like me
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.
So perhaps someone can shed some light on the status of pull requests to n00bs like me

-
- Normal user
- Posts: 497
- Joined: 04 Oct 2016, 23:16
Re: ESP Easy Github pull requests
+1TD-er wrote: ↑05 Sep 2017, 00:10 What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.
So perhaps someone can shed some light on the status of pull requests to n00bs like me![]()
Any news? Piling up of pull-req is not helping with who wants to update/enhance what's not yet approved

2nd n00b here

My TINDIE Store where you can find all ESP8266 boards I manufacture --> https://www.tindie.com/stores/GiovanniCas/
My Wiki Project page with self-made PCB/devices --> https://www.letscontrolit.com/wiki/inde ... :Papperone
My Wiki Project page with self-made PCB/devices --> https://www.letscontrolit.com/wiki/inde ... :Papperone
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
i merged a bunch of pull requests. i'll unstick this (very old) topic and create a new one to indicate whats going on.
-
- Normal user
- Posts: 232
- Joined: 02 Feb 2017, 12:12
Re: ESP Easy Github pull requests
Oh it seems i cant unstick it. 

-
- Core team member
- Posts: 9922
- Joined: 01 Sep 2017, 22:13
- Location: the Netherlands
Re: ESP Easy Github pull requests
So we're stuck with it? 

-
- Normal user
- Posts: 1385
- Joined: 17 Jun 2018, 20:41
- Location: USA
Re: ESP Easy Github pull requests
This topic is stale and no longer relevant. I suggest it be removed from the sticky list.
- Thomas
- Thomas
-
- Core team member
- Posts: 3621
- Joined: 19 Jan 2017, 12:56
- Location: Hudiksvall, Sweden
Re: ESP Easy Github pull requests
Done
ESP Easy Flasher [flash tool and wifi setup at flash time]
ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you

ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you



Who is online
Users browsing this forum: Anthropic Claude Bot [bot], OpenAI GPTBot [bot] and 28 guests