Github - Playground push request

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
Zodiac69
Normal user
Posts: 85
Joined: 13 Jun 2016, 17:20

Github - Playground push request

#1 Post by Zodiac69 » 16 Aug 2018, 22:42

Hi All

1st Plugin...
How do i push it to the PluginPlayground?

TD-er
Core team member
Posts: 8739
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Github - Playground push request

#2 Post by TD-er » 17 Aug 2018, 20:35

Steps when using git local on your computer:
- You need to have a Github account.
- Fork the repository to your own account and clone that one to your computer.
- Create a branch on your local copy of the clone.
- Make the changes you want and create a commit containing a proper description of what you did and including the file changes.
(You may add several commits to the same branch)
- Push the commit to your fork of the repository on Github.
- Create a pull request on Github to the original repository of letscontrolit.


There is a shortcut possible, when you don't want (or know how to) use git on your computer:
- You need to have a Github account.
- Then fork the repository to your own account.
- Create a branch on your fork on Github.
- Make the changed you want directly on Github and create a commit containing a proper description of what you did and including the file changes.
(You may add several commits to the same branch)
- Push the commit to your fork of the repository on Github. (is done automatically when you commit directly on Github)
- Create a pull request on Github to the original repository of letscontrolit.

Zodiac69
Normal user
Posts: 85
Joined: 13 Jun 2016, 17:20

Re: Github - Playground push request

#3 Post by Zodiac69 » 17 Aug 2018, 22:17

Hi TD-er

It seems that the request is there under closed pull request.
So i presume that the owner need to accept the request before it will be available?

TD-er
Core team member
Posts: 8739
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Github - Playground push request

#4 Post by TD-er » 18 Aug 2018, 12:58

I am not the owner of the playground, but I can do merges.
I will look at it to see if there is something in your code that may break stuff and often I leave it open for a few days so others can have a look at it too.

Post Reply

Who is online

Users browsing this forum: No registered users and 51 guests