Let's Control It

Kim_Panda

@GravityRZ I had a look in https://github.com/letscontrolit/ESPEasy/archive/refs/tags/mega-20210503.zip and see, that there is still the very first old version of _P003_Pulse.ino. It is not my new enhanced version that I developed under https://github.com/letscontrolit/ESPEasy/pull/3545 . It seems, ...

Kim_Panda

GravityRZ wrote: ↑11 Apr 2021, 15:59 thanks
testing the 0411 build now.
...
give me some time to see how stable it is.

@GravityRZ: You may want the documentation to interpret the statistical log messages.
I attach here the relevant page as .pdf.

Generic-Pulse counter-ESPEasy_2.1-beta1_documentation.zip: (110.47 KiB) Downloaded 201 times

Kim_Panda

Pre-release builds can be downloaded from the PR page , from the 'build-list' at the end of the page, select one of the Details links, then from that page select the Artifacts (1) link on the right, and download the Binaries.zip file, where you can extract the desired .bin file. (IMHO: Super useful...

Kim_Panda

GravityRZ wrote: ↑08 Apr 2021, 20:12 looking forward testing it

Today I did a minor enhancement to the documentation.
I completed all my work. I am not familiar with the formal release process in ESPEasy,
but I hope that @TD-er will provide you soon with a build, so you could do your test.

Kim_Panda

Your question: For example what if you have a command to write something on a display. e.g. writeToDisplay,column,row,text What will be done when giving this command: writeToDisplay,,,"This is a text" Is it by default row = 0 and column = 0? Or the next line? I don't know. That depends on ...

Kim_Panda

I don't fully understand, what you are going to say. But step by step: This also enforces you only can have optional parameters at the end. Is this a strongly intended restriction/limitation? :?: It inhibits further flexibility. I don't see why current rules would break if we support empty variables...

Kim_Panda

TD-er wrote: ↑28 Mar 2021, 10:11 I added some remarks to your PR.

All requested changes are done. And also command handling is revised. Docu is updated. See PR.
I closed the conversations that I regard as completed.
New Version is pushed to
https://github.com/KimPanda4/ESPEasy/tr ... nhancement
puhhh

Kim_Panda

Ath wrote: ↑28 Mar 2021, 18:08 It does indeed resolve & close the conversation, making it easier to track what's not resolved yet (at least, that's how I use it )

Ok, thanks.

Kim_Panda

while implementing the new command feature with a TaskNumber-prefix https://espeasy.readthedocs.io/en/latest/Reference/Command.html ("Command a specific task for multiple instances of a plugin") I found that multiple optional parameters seem not be supported properly and I wonder if that i...

Kim_Panda

Thanks a lot.

Kim_Panda

During my recent development I found it helpful to see the current timestamp at the end of the build process. Timestamp.png This makes it more save to allocate the related .bin file, specially if you do several consecutive builds. Currently only the duration of the build is shown. I achived that by ...

Kim_Panda

I added some remarks to your PR. All changes are for your takeover now in https://github.com/KimPanda4/ESPEasy/tree/P003-2.2-PULSE-enhancement I did a successful quick test and also a successful test build for custom_ESP8266_4M1M and custom_ESP32_4M316k. Do I need to press the "Resolve convers...

Kim_Panda

What can be done to overcome this: Your three approaches are valid, each with its disadvantages. And when the only place with a certain guaranty for timely processing is in the trigger, I agree, that the best approach is, to move some more functionality in the trigger and use the time difference be...

Kim_Panda

TD-er wrote: ↑27 Mar 2021, 14:59 By the way the network connection methods used in ESPEasy have been asynchronous for at least 3 years now.
Still some callbacks are not, like WiFiClient.connect and performing a DNS resolve.

Ahh, this sounds much better.
Thanks for explanation.

Kim_Panda

Meaning no other code will be executed, except for interrupt code, maybe. The reason for this "maybe" is that I am not sure if GPIO-triggered interrupts are at the same level as WiFi interrupts. I think you are right. I think I saw in my test, that interrupts were still counted in the blo...

Kim_Panda

Network activity, like "MQTT reconnect" can be so called "blocking" code. :( hmmm, bad news. Had somebody thought about making these IP-drivers non blocking (asynchronous) ? From an idealistic point of view, this would be the obvious thing to do, rather than trying to sanitize t...

Kim_Panda

can you see anything which would cause it to mallfunction when the flow is around 25 pulses a minute The short answer to your question is "no". But here is the long answer: Interpretation of the logs: In both cases only clean pulses were detected, i.e. that all three read steps always did...

Kim_Panda

that was clear but i did not understood what to do in the second window Log level can be set in Tools -> Advanced. You can set the log level for serial, a syslog service, web log and if included in the build log to SD card. Here is an example screenshot of the two parallel windows Log-Example.jpg

Kim_Panda

@TD-er:
I am not quite sure, if I formally correctly completed the Pull request.
https://github.com/letscontrolit/ESPEas ... -612946234
Can you please have a look. I think I resolved all issues and the change is ready.

Kim_Panda

Hey, that sounds good! Thanks for testing. Without knowing the details, I would say, that the situations where you count too much pulses (+1), the debounce time is too short and you are sometimes counting a bounce. Otherwise too few pulses (-1/-3) can mean, that the debounce time is too long and you...

Kim_Panda

I published a small correction of a reference in the P003 Commands docu, because I saw, that is was not appropriate in the context of the "Command Reference" page. NB: The new PULSE counter is meanwhile since 3 weeks counting my gas meter 100% correctly (no false count at all 8-) ) with ar...

Kim_Panda

Does this mean existing settings may no longer work after update? I think no, because the existing settings should work unchanged, but the new PULSE mode does now the additional checks in order to be more accurate. The old modes were in this sense more tolerant, but not as accurate. Let's see, what...

Kim_Panda

I also did a quick test with ESP_Easy_mega_20210317_normal_ESP8266_4M1M.bin For me its working in both modes. @GravityRZ: Please see what Debounce time you use. You may need to adjust it. When its too long, nothing is counted, if the pulse is not stable after Debounce time for another period of the ...

Kim_Panda

EDIT: or am i misinterpreting things that the above descibed total time(pulsehigh+pulselow) is not yet in the 20210223 build You are right, the new version is not yet available. Coming soon. I will let you know here. :ugeek: [/quote] @GravityRZ: Here we are! I completed my work on the P003 enhancem...

Kim_Panda

Hi TD-er, I have finally completed my P003 Pulse Counter enhancement and issue a Pull Request in a minute. I followed your "cook book" for pull requests, from above. I hope I followed the procedure as intended. It's not easy doing it for the first time. You will see, that there are a lot o...

Kim_Panda

RTC memory is not flash. RTC memory is just memory that doesn't get erased at a reboot, as long as the power remains. Thanks TD-er for that good hint! I was not aware of that fact and I did a quick research which now ties pieces together for me. What is called UserVar (UserVarStruct) in P003 is act...

Kim_Panda

Well the pulse counter is a bit strange here, especially when you're using a formula. The task values are restored at (warm) boot, but if I remember correctly the Pulse counter does do something different to other plugins regarding the values stored in the UserVar struct. (the values that are store...

Kim_Panda

so how would you explain that current ota flash erases the task values. like i said al previous ota flashes were ok so something must have changed in the ota process for now not a big deal but if this is not how it should work then we need to investigate. I was interested to see if I can reproduce ...

Kim_Panda

[/quote]

GravityRZ wrote: ↑13 Mar 2021, 15:24 EDIT: or am i misinterpreting things that the above descibed total time(pulsehigh+pulselow) is not yet in the 20210223 build

You are right, the new version is not yet available. Coming soon. I will let you know here.

Kim_Panda

I have been testing and enhancing the P003 now for several weeks and I'm now satisfied with the new PULSE modes. I used it now for over a week with not a single false count to digitalize my analogue gas meter. My use case : My analogue gas meter (ACTARIS G4 RF1) has a on its lowest wheel a small mag...

Kim_Panda

So there is a need for disabling it in handling ISR calls That is very important to know. It sounds odd, but I assume there are good reasons for doing so. Using 2 timer values can also help to filter out spikes I see the point and it sounds good, but somehow contradicts to my approach. With my solu...

Kim_Panda

Thanks a lot for this good hints. But first the good message: The version I sent with the previous post is counting since 3 days my gas meter pulses 100% correctly. The optional statistic logging quickly helped me in tuning the debounce time and I see now exactly in which filter step, how many false...

Kim_Panda

Ahh, I was not aware of this functionality. In my case (I'll explain below), I think, the combination of setPluginTaskTimer and PLUGIN_TIMER_IN is more appropriate, as I do not want to automatically trigger connected controllers. And I am very happy :) that I got it immediately perfectly running, af...

Kim_Panda

Ahh, I think I got it now, after I looked, how it is implemented in Scheduler.cpp. I was mislead by the 5 years old :shock: explanation in viewtopic.php?f=6&t=5900&p=32089&hilit= ... mer#p32089 . this is not valid any more. What I found from Scheduler.cpp is the following. Please correct...

Kim_Panda

Thanks a lot TD-er. I will try, when I got it running. While testing, I just came across a strange thing. I put a logging inside the main function "boolean Plugin_003(..." for logging the "function" and the "event->TaskIndex". I found, that all functions are called with...

Kim_Panda

Stop, Stop

I got the scheduling working

after a further compile. I do not know why

. PLUGIN_ONLY_TIMER_IN is called now.
I will come back, when I got it tested/working.
I may then need help to merge my code with parallel updates push my results to you.
Thanks for now!

Kim_Panda

Hi, I'm back again and thanks to GravityRZ for sharing your rule solution. It is an interesting and tricky way. I have not tried it yet, because I am still following my original approach to understand and enhance the plugin 003 code. If I fail, I'll come back to your approach. Over the last two week...

Kim_Panda

I created a pull request for it with your code changes. See: https://github.com/letscontrolit/ESPEasy/pull/3482 I will have a good look at it later this evening. To help you understand what is needed for submitting future pull requests (PR) :) ...... @TD-er: I have the enhancement now more than a w...

Kim_Panda

I created a pull request for it with your code changes. See: https://github.com/letscontrolit/ESPEasy/pull/3482 I will have a good look at it later this evening. To help you understand what is needed for submitting future pull requests (PR) :) ...... @TD-er: Thanks for your positive positive respon...

Kim_Panda

@GravityRZ: regarding the time modification i see that you just modified it instead of making a second option. I do not like this implementation because at the moment a lot of people use the time between pulses to calculate eg a waterflow if it now only times the duration of the pulse(eg the high or...

Kim_Panda

Hello Community, I developed an enhancement to stabilize the Generic Pulse Counter P003 with two further Mode Types. I want to offer that enhancement as give-back to the community but have no experience on doing it in a community forum like this. After spending a lot of time in that, I ran out of ti...

Search found 41 matches