Question about mega-20190925 release

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
mackowiakp
Normal user
Posts: 182
Joined: 07 Jun 2018, 06:47
Location: Gdynia/Poland

Question about mega-20190925 release

#1 Post by mackowiakp » 25 Sep 2019, 07:58

Does mega-20190925 contain ADC and WiFi improvements released in mega-20190925 (without binaries) ?

TD-er
Core team member
Posts: 1797
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Question about mega-20190925 release

#2 Post by TD-er » 25 Sep 2019, 09:26

See: https://github.com/letscontrolit/ESPEas ... #L195-L207

I have selected the file with the specific tag of last night's build: https://github.com/letscontrolit/ESPEas ... #L195-L207
You can also browse the repository on GitHub and then select the right tag to see whether a change was already present in a certain build.
This selection is in the upper left corner, right below the "<>Code" tab.

It does also show the last commit where that file was changed, until then.

TL;DR
Yes :)

mackowiakp
Normal user
Posts: 182
Joined: 07 Jun 2018, 06:47
Location: Gdynia/Poland

Re: Question about mega-20190925 release

#3 Post by mackowiakp » 25 Sep 2019, 14:21

So as I understand, ADC and WiFi improvements are included in 20190925 release.

TD-er
Core team member
Posts: 1797
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Question about mega-20190925 release

#4 Post by TD-er » 25 Sep 2019, 15:05

Yep.
But Clumsy-Stephan already found an issue with it when running deep sleep.
Currently the reading of the ADC is just echo'ing the last reading when the WiFi is trying to connect.
When you use deep sleep, you may need to wait a bit more to get a proper reading before going to sleep again.
So this fix may need some tweaking here to only stop reading ADC values during RF calibration.
Problem is, there is no event indicating when that's taking place.

mackowiakp
Normal user
Posts: 182
Joined: 07 Jun 2018, 06:47
Location: Gdynia/Poland

Re: Question about mega-20190925 release

#5 Post by mackowiakp » 25 Sep 2019, 15:20

This is not a problem for me. I don't use deep sleep. More importantly, there is a chance that nodeMCU will not be reboot on such an occasion. We will observe and see ...

Post Reply

Who is online

Users browsing this forum: No registered users and 28 guests