Pulse Counter P003 enhancement. How to give back?

Moderators: grovkillen, Stuntteam, TD-er

Message
Author
TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Pulse Counter P003 enhancement. How to give back?

#101 Post by TD-er » 06 May 2021, 21:23

As you may have seen, there was quite a delay between the last nightly build and the one before (> 2 months, which is exceptionally long)
This was mainly because of issues with build size.
I also did not want to change too much things at once (failed on that one a bit....) so I can merge your PR so it can be tested a bit more before the next build is made.

If Ton does not have any objections, I will merge it.

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: Pulse Counter P003 enhancement. How to give back?

#102 Post by Ath » 06 May 2021, 22:21

TD-er wrote: 06 May 2021, 21:23 If Ton does not have any objections, I will merge it.
I don't mind, but I haven't used / tested it, so actually can't object if the code seems stable ;)
/Ton (PayPal.me)

GravityRZ
Normal user
Posts: 206
Joined: 23 Dec 2019, 21:24

Re: Pulse Counter P003 enhancement. How to give back?

#103 Post by GravityRZ » 08 May 2021, 16:29

i am using the new P003 enhancement for quiet some time now (build 0411) and can tell that it has been very stable
I use it in a production environment (watermeter)

@TD-er
if you merge it please point me to the location so i can download it.(assuming you do not create a new release)

rron
Normal user
Posts: 22
Joined: 13 Mar 2021, 14:33

Re: Pulse Counter P003 enhancement. How to give back?

#104 Post by rron » 15 May 2021, 11:01

@gravityRZ,

Where can I find this 0411 build? Or is this already in the stable release?

GravityRZ
Normal user
Posts: 206
Joined: 23 Dec 2019, 21:24

Re: Pulse Counter P003 enhancement. How to give back?

#105 Post by GravityRZ » 15 May 2021, 22:04

i downloaded the 0411 version as a beta.

the current 0503 release does habe the new P003 enhancement but somehow this is a very old version.

you are better of downloading the 0223 release

i attached the 0411 release in case you want it.

let me know if you need a different one

ESPEasy_normal_ESP8266_4M1M.zip
(2.23 MiB) Downloaded 184 times

rron
Normal user
Posts: 22
Joined: 13 Mar 2021, 14:33

Re: Pulse Counter P003 enhancement. How to give back?

#106 Post by rron » 16 May 2021, 11:54

Thanks, I will try this version and let you know.

rron
Normal user
Posts: 22
Joined: 13 Mar 2021, 14:33

Re: Pulse Counter P003 enhancement. How to give back?

#107 Post by rron » 16 May 2021, 12:58

GravityRZ wrote: 15 May 2021, 22:04 i downloaded the 0411 version as a beta.

the current 0503 release does habe the new P003 enhancement but somehow this is a very old version.

you are better of downloading the 0223 release

i attached the 0411 release in case you want it.

let me know if you need a different one


ESPEasy_normal_ESP8266_4M1M.zip
Hi GravityRZ,

What settings are you using and is giving the best results?

GravityRZ
Normal user
Posts: 206
Joined: 23 Dec 2019, 21:24

Re: Pulse Counter P003 enhancement. How to give back?

#108 Post by GravityRZ » 16 May 2021, 15:54

at the moment i am using 88ms when using pulse low

it al depends on how long the signal is low
if this time is very short then you also need a short debounce time, roughly 1/10 of the time the signal is low.

in my situation i use it for a watermeter.
this can have a flow of 0-25 liters a second so this affects the pulselow time also
you want to have a debounce time which will work when the flow is low but also still works when the flow is high

rron
Normal user
Posts: 22
Joined: 13 Mar 2021, 14:33

Re: Pulse Counter P003 enhancement. How to give back?

#109 Post by rron » 16 May 2021, 22:30

GravityRZ wrote: 16 May 2021, 15:54 at the moment i am using 88ms when using pulse low

it al depends on how long the signal is low
if this time is very short then you also need a short debounce time, roughly 1/10 of the time the signal is low.

in my situation i use it for a watermeter.
this can have a flow of 0-25 liters a second so this affects the pulselow time also
you want to have a debounce time which will work when the flow is low but also still works when the flow is high
Ok thanks I will start with your setting and let you know.

mdax82
Normal user
Posts: 17
Joined: 15 May 2021, 08:57

Re: Pulse Counter P003 enhancement. How to give back?

#110 Post by mdax82 » 22 Jun 2021, 09:37

Also using the "0411" build with a bk-g4 gas meter. Works quite nicely - the false counts I had previously are gone and the debug output gives a lot of insight. Great job thanks!

Post Reply

Who is online

Users browsing this forum: No registered users and 33 guests