Still bugs in new INA219.ino for quad INA219 support

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
ogollemon
New user
Posts: 4
Joined: 20 Apr 2016, 21:01

Still bugs in new INA219.ino for quad INA219 support

#1 Post by ogollemon » 20 Apr 2016, 21:10

Hi everyone,

I am still struggling with a bug in the code. I've modified the original Plugin 027 INA219 code to support four possible INA's.
Unfortunately I don't get a clue on how to save the INA address for the specific task only. As of now, the last saved task will overrule all other INA device addresses.

Can someone please have a look? Or provide me with a hint on how to save the address for the specific task?
Code: https://github.com/ogollemon/ESPEasy/bl ... INA219.ino

Thx,

ogo

Drum
Normal user
Posts: 300
Joined: 07 Feb 2016, 11:56

Re: Still bugs in new INA219.ino for quad INA219 support

#2 Post by Drum » 15 Jul 2016, 15:32

I don't know exactly how these plugins work, but I think what you are looking for is at the top,

uint8_t Plugin_027_INA219_address = 0x40; // 0x40 /0x41 A0/0x44 A1/0x45 A0 and A1

Do some reading on the PCF8574 plugin. This might give you an idea how to modify the INA219 plugin to do this. I would think you would have a selection for board 1 to 4, a selection for board and measurement combined or a separate plugin for each address(might be easier). No idea otherwise, a lot of this stuff is still pretty much magic to me. ;)
In any case you are not the first person to ask.

BertB
Normal user
Posts: 1049
Joined: 25 Apr 2015, 14:39

Re: Still bugs in new INA219.ino for quad INA219 support

#3 Post by BertB » 04 Feb 2017, 17:54

Hi,

Just add: ina219_i2caddr = Settings.TaskDevicePluginConfig[event->TaskIndex][0];

So that PLUGIN_READ changes into:

Code: Select all

    case PLUGIN_READ:
      {
        // shuntvoltage = Plugin_027_getShuntVoltage_mV();
        // busvoltage = Plugin_027_getBusVoltage_V();
        // current_mA = Plugin_027_getCurrent_mA();
        // loadvoltage = Plugin_027_getBusVoltage_V() + (Plugin_027_getShuntVoltage_mV() / 1000);
        ina219_i2caddr = Settings.TaskDevicePluginConfig[event->TaskIndex][0];
        Serial.println(ina219_i2caddr);
        float value=0;
        switch(Settings.TaskDevicePluginConfig[event->TaskIndex][1])
        ...
        

StefanD
Normal user
Posts: 21
Joined: 28 Jan 2017, 20:07

Re: Still bugs in new INA219.ino for quad INA219 support

#4 Post by StefanD » 05 Mar 2017, 09:26

Hi everyone,
I did the modifications Bert suggested and everything it is working properly now. I want to mention the one line must be added in the beginning:
uint8_t ina219_i2caddr; . Also the modified output for the sensor to have instead of always "INA: value" for all 3 options, separate topics INA: voltage, INA: current and INA:power depending of which selection is made. In this way it this possible to send to Domoticz all 3 values from the same sensor.Bellow it is the modified plugin:

//#######################################################################################################
//######################### Plugin 027: INA219 DC Voltage/Current sensor ################################
//#######################################################################################################

#define PLUGIN_027
#define PLUGIN_ID_027 27
#define PLUGIN_NAME_027 "Voltage & Current (DC) - INA219"
#define PLUGIN_VALUENAME1_027 "Voltage"

uint8_t Plugin_027_INA219_address = 0x40; // 0x40 /0x41 A0/0x44 A1/0x45 A0 and A1
//boolean Plugin_027_init = false;
#define INA219_READ (0x01)
#define INA219_REG_CONFIG (0x00)
#define INA219_CONFIG_RESET (0x8000) // Reset Bit

#define INA219_CONFIG_BVOLTAGERANGE_MASK (0x2000) // Bus Voltage Range Mask
#define INA219_CONFIG_BVOLTAGERANGE_16V (0x0000) // 0-16V Range
#define INA219_CONFIG_BVOLTAGERANGE_32V (0x2000) // 0-32V Range

#define INA219_CONFIG_GAIN_MASK (0x1800) // Gain Mask
#define INA219_CONFIG_GAIN_1_40MV (0x0000) // Gain 1, 40mV Range
#define INA219_CONFIG_GAIN_2_80MV (0x0800) // Gain 2, 80mV Range
#define INA219_CONFIG_GAIN_4_160MV (0x1000) // Gain 4, 160mV Range
#define INA219_CONFIG_GAIN_8_320MV (0x1800) // Gain 8, 320mV Range

#define INA219_CONFIG_BADCRES_MASK (0x0780) // Bus ADC Resolution Mask
#define INA219_CONFIG_BADCRES_9BIT (0x0080) // 9-bit bus res = 0..511
#define INA219_CONFIG_BADCRES_10BIT (0x0100) // 10-bit bus res = 0..1023
#define INA219_CONFIG_BADCRES_11BIT (0x0200) // 11-bit bus res = 0..2047
#define INA219_CONFIG_BADCRES_12BIT (0x0400) // 12-bit bus res = 0..4097

#define INA219_CONFIG_SADCRES_MASK (0x0078) // Shunt ADC Resolution and Averaging Mask
#define INA219_CONFIG_SADCRES_9BIT_1S_84US (0x0000) // 1 x 9-bit shunt sample
#define INA219_CONFIG_SADCRES_10BIT_1S_148US (0x0008) // 1 x 10-bit shunt sample
#define INA219_CONFIG_SADCRES_11BIT_1S_276US (0x0010) // 1 x 11-bit shunt sample
#define INA219_CONFIG_SADCRES_12BIT_1S_532US (0x0018) // 1 x 12-bit shunt sample
#define INA219_CONFIG_SADCRES_12BIT_2S_1060US (0x0048) // 2 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_4S_2130US (0x0050) // 4 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_8S_4260US (0x0058) // 8 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_16S_8510US (0x0060) // 16 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_32S_17MS (0x0068) // 32 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_64S_34MS (0x0070) // 64 x 12-bit shunt samples averaged together
#define INA219_CONFIG_SADCRES_12BIT_128S_69MS (0x0078) // 128 x 12-bit shunt samples averaged together

#define INA219_CONFIG_MODE_MASK (0x0007) // Operating Mode Mask
#define INA219_CONFIG_MODE_POWERDOWN (0x0000)
#define INA219_CONFIG_MODE_SVOLT_TRIGGERED (0x0001)
#define INA219_CONFIG_MODE_BVOLT_TRIGGERED (0x0002)
#define INA219_CONFIG_MODE_SANDBVOLT_TRIGGERED (0x0003)
#define INA219_CONFIG_MODE_ADCOFF (0x0004)
#define INA219_CONFIG_MODE_SVOLT_CONTINUOUS (0x0005)
#define INA219_CONFIG_MODE_BVOLT_CONTINUOUS (0x0006)
#define INA219_CONFIG_MODE_SANDBVOLT_CONTINUOUS (0x0007)

#define INA219_REG_SHUNTVOLTAGE (0x01)
#define INA219_REG_BUSVOLTAGE (0x02)
#define INA219_REG_POWER (0x03)
#define INA219_REG_CURRENT (0x04)
#define INA219_REG_CALIBRATION (0x05)

uint8_t ina219_i2caddr;
uint32_t ina219_calValue;
// The following multipliers are used to convert raw current and power
// values to mA and mW, taking into account the current config settings
uint32_t ina219_currentDivider_mA;

boolean Plugin_027(byte function, struct EventStruct *event, String& string)
{
boolean success = false;

switch (function)
{

case PLUGIN_DEVICE_ADD:
{
Device[++deviceCount].Number = PLUGIN_ID_027;
Device[deviceCount].Type = DEVICE_TYPE_I2C;
Device[deviceCount].VType = SENSOR_TYPE_SINGLE;
Device[deviceCount].Ports = 0;
Device[deviceCount].PullUpOption = false;
Device[deviceCount].InverseLogicOption = false;
Device[deviceCount].FormulaOption = true;
Device[deviceCount].ValueCount = 1;
Device[deviceCount].SendDataOption = false;
Device[deviceCount].TimerOption = true;
Device[deviceCount].GlobalSyncOption = true;
break;
}

case PLUGIN_GET_DEVICENAME:
{
string = F(PLUGIN_NAME_027);
break;
}

case PLUGIN_GET_DEVICEVALUENAMES:
{
strcpy_P(ExtraTaskSettings.TaskDeviceValueNames[0], PSTR(PLUGIN_VALUENAME1_027));
break;
}

case PLUGIN_WEBFORM_LOAD:
{
byte choice = Settings.TaskDevicePluginConfig[event->TaskIndex][0];
String options[3];
options[0] = F("Voltage");
options[1] = F("Current");
options[2] = F("Power");
int optionValues[3];
optionValues[0] = 0;
optionValues[1] = 1;
optionValues[2] = 2;
string += F("<TR><TD>Report:<TD><select name='plugin_026_value'>");
for (byte x = 0; x < 3; x++)
{
string += F("<option value='");
string += optionValues[x];
string += "'";
if (choice == optionValues[x])
string += F(" selected");
string += ">";
string += options[x];
string += F("</option>");
}
string += F("</select>");
byte choice2 = Settings.TaskDevicePluginConfig[event->TaskIndex][1];
String options2[4];
options2[0] = F("0x40");
options2[1] = F("0x41 -> A0");
options2[2] = F("0x44 -> A1");
options2[3] = F("0x45 -> A0+A1");
uint8_t optionValues2[4];
optionValues2[0] = 0x40;
optionValues2[1] = 0x41;
optionValues2[2] = 0x44;
optionValues2[3] = 0x45;
string += F("<TR><TD>I2C Address:<TD><select name='plugin_027_adr'>");
for (byte x = 0; x < 4; x++)
{
string += F("<option value='");
string += optionValues2[x];
string += "'";
if (choice2 == optionValues2[x])
string += F(" selected");
string += ">";
string += options2[x];
string += F("</option>");
}
string += F("</select>");

success = true;
break;
}

case PLUGIN_WEBFORM_SAVE:
{
String plugin1 = WebServer.arg("plugin_026_value");
Settings.TaskDevicePluginConfig[event->TaskIndex][0] = plugin1.toInt();
String plugin2 = WebServer.arg("plugin_027_adr");
Settings.TaskDevicePluginConfig[event->TaskIndex][1] = plugin2.toInt();
// Plugin_027_init = false; // Force device setup next time??
success = true;
break;
}

case PLUGIN_INIT:
{
// boolean Plugin_027_init = true; // Force device setup??
Plugin_027_INA219_address = Settings.TaskDevicePluginConfig[event->TaskIndex][1];
Plugin_027_begin();
success = true;
break;
}

case PLUGIN_READ:
{
// shuntvoltage = Plugin_027_getShuntVoltage_mV();
// busvoltage = Plugin_027_getBusVoltage_V();
// current_mA = Plugin_027_getCurrent_mA();
// loadvoltage = Plugin_027_getBusVoltage_V() + (Plugin_027_getShuntVoltage_mV() / 1000);
ina219_i2caddr = Settings.TaskDevicePluginConfig[event->TaskIndex][1];
Serial.println(ina219_i2caddr);
float value=0;
switch(Settings.TaskDevicePluginConfig[event->TaskIndex][0])
{
case 0:
{
value = Plugin_027_getBusVoltage_V() + (Plugin_027_getShuntVoltage_mV() / 1000);
UserVar[event->BaseVarIndex] = value;
String log = F("INA : voltage: ");
log += value;
addLog(LOG_LEVEL_INFO,log);
success = true;
break;
}
case 1:
{
value = Plugin_027_getCurrent_mA()/1000;
UserVar[event->BaseVarIndex] = value;
String log = F("INA : current: ");
log += value;
addLog(LOG_LEVEL_INFO,log);
success = true;
break;
}
case 2:
{
value = (Plugin_027_getBusVoltage_V() + (Plugin_027_getShuntVoltage_mV() / 1000)) * Plugin_027_getCurrent_mA() / 1000;
UserVar[event->BaseVarIndex] = value;
String log = F("INA : power: ");
log += value;
addLog(LOG_LEVEL_INFO,log);
success = true;
break;
}
}
}
}
return success;
}

//**************************************************************************/
// Sends a single command byte over I2C
//**************************************************************************/
void Plugin_027_wireWriteRegister (uint8_t reg, uint16_t value)
{
Wire.beginTransmission(Plugin_027_INA219_address);
Wire.write(reg); // Register
Wire.write((value >> 8) & 0xFF); // Upper 8-bits
Wire.write(value & 0xFF); // Lower 8-bits
Wire.endTransmission();
}

//**************************************************************************/
// Reads a 16 bit values over I2C
//**************************************************************************/
void Plugin_027_wireReadRegister(uint8_t reg, uint16_t *value)
{

Wire.beginTransmission(Plugin_027_INA219_address);
Wire.write(reg); // Register
Wire.endTransmission();

delay(1); // Max 12-bit conversion time is 586us per sample

Wire.requestFrom(Plugin_027_INA219_address, (uint8_t)2);
// Shift values to create properly formed integer
*value = ((Wire.read() << 8) | Wire.read());
}

//**************************************************************************/
// Configures to INA219 to be able to measure up to 32V and 2A
/**************************************************************************/
void Plugin_027_setCalibration_32V_2A(void)
{
ina219_calValue = 4027;

// Set multipliers to convert raw current/power values
ina219_currentDivider_mA = 10; // Current LSB = 100uA per bit (1000/100 = 10)

// Set Calibration register to 'Cal' calculated above
Plugin_027_wireWriteRegister(INA219_REG_CALIBRATION, ina219_calValue);

// Set Config register to take into account the settings above
uint16_t config = INA219_CONFIG_BVOLTAGERANGE_32V |
INA219_CONFIG_GAIN_8_320MV |
INA219_CONFIG_BADCRES_12BIT |
INA219_CONFIG_SADCRES_12BIT_1S_532US |
INA219_CONFIG_MODE_SANDBVOLT_CONTINUOUS;
Plugin_027_wireWriteRegister(INA219_REG_CONFIG, config);
}

//**************************************************************************/
// Configures to INA219 to be able to measure up to 32V and 1A
//**************************************************************************/
void Plugin_027_setCalibration_32V_1A(void)
{

ina219_calValue = 10240;

// Set multipliers to convert raw current/power values
ina219_currentDivider_mA = 25; // Current LSB = 40uA per bit (1000/40 = 25)

// Set Calibration register to 'Cal' calculated above
Plugin_027_wireWriteRegister(INA219_REG_CALIBRATION, ina219_calValue);

// Set Config register to take into account the settings above
uint16_t config = INA219_CONFIG_BVOLTAGERANGE_32V |
INA219_CONFIG_GAIN_8_320MV |
INA219_CONFIG_BADCRES_12BIT |
INA219_CONFIG_SADCRES_12BIT_1S_532US |
INA219_CONFIG_MODE_SANDBVOLT_CONTINUOUS;
Plugin_027_wireWriteRegister(INA219_REG_CONFIG, config);
}

//**************************************************************************/
// Configures to INA219 to be able to measure up to 16V and 400mA
//**************************************************************************/
void Plugin_027_setCalibration_16V_400mA(void) {

ina219_calValue = 8192;

// Set multipliers to convert raw current/power values
ina219_currentDivider_mA = 20; // Current LSB = 50uA per bit (1000/50 = 20)

// Set Calibration register to 'Cal' calculated above
Plugin_027_wireWriteRegister(INA219_REG_CALIBRATION, ina219_calValue);

// Set Config register to take into account the settings above
uint16_t config = INA219_CONFIG_BVOLTAGERANGE_16V |
INA219_CONFIG_GAIN_1_40MV |
INA219_CONFIG_BADCRES_12BIT |
INA219_CONFIG_SADCRES_12BIT_1S_532US |
INA219_CONFIG_MODE_SANDBVOLT_CONTINUOUS;
Plugin_027_wireWriteRegister(INA219_REG_CONFIG, config);
}


//**************************************************************************/
// Setups the HW (defaults to 32V and 2A for calibration values)
//**************************************************************************/

void Plugin_027_begin(void) {
// Plugin_027_INA219_address = Plugin_027_INA219_address; // INA219_ADDRESS;
ina219_currentDivider_mA = 0;

// Set chip to large range config values to start
Plugin_027_setCalibration_32V_2A();
}

//**************************************************************************/
// Gets the raw bus voltage (16-bit signed integer, so +-32767)
//**************************************************************************/
int16_t Plugin_027_getBusVoltage_raw() {
uint16_t value;
Plugin_027_wireReadRegister(INA219_REG_BUSVOLTAGE, &value);

// Shift to the right 3 to drop CNVR and OVF and multiply by LSB
return (int16_t)((value >> 3) * 4);
}

//**************************************************************************/
// Gets the raw shunt voltage (16-bit signed integer, so +-32767)
//**************************************************************************/
int16_t Plugin_027_getShuntVoltage_raw() {
uint16_t value;
Plugin_027_wireReadRegister(INA219_REG_SHUNTVOLTAGE, &value);
return (int16_t)value;
}

//**************************************************************************/
// Gets the raw current value (16-bit signed integer, so +-32767)
//**************************************************************************/
int16_t Plugin_027_getCurrent_raw() {
uint16_t value;

// Sometimes a sharp load will reset the INA219, which will
// reset the cal register, meaning CURRENT and POWER will
// not be available ... avoid this by always setting a cal
// value even if it's an unfortunate extra step
Plugin_027_wireWriteRegister(INA219_REG_CALIBRATION, ina219_calValue);

// Now we can safely read the CURRENT register!
Plugin_027_wireReadRegister(INA219_REG_CURRENT, &value);

return (int16_t)value;
}

//**************************************************************************/
// Gets the shunt voltage in mV (so +-327mV)
//**************************************************************************/
float Plugin_027_getShuntVoltage_mV() {
int16_t value;
value = Plugin_027_getShuntVoltage_raw();
return value * 0.01;
}

//**************************************************************************/
// Gets the shunt voltage in volts
//**************************************************************************/
float Plugin_027_getBusVoltage_V() {
int16_t value = Plugin_027_getBusVoltage_raw();
return value * 0.001;
}

//**************************************************************************/
// Gets the current value in mA, taking into account the
// config settings and current LSB
//**************************************************************************/
float Plugin_027_getCurrent_mA() {
float valueDec = Plugin_027_getCurrent_raw();
valueDec /= ina219_currentDivider_mA;
return valueDec;
}

krikk
Normal user
Posts: 118
Joined: 28 Feb 2017, 07:57
Location: Austria
Contact:

Re: Still bugs in new INA219.ino for quad INA219 support

#5 Post by krikk » 05 Mar 2017, 09:39

nice that you did this, but it would be better if you could do a pull request via github...

for tutorial how to to this, have a look at this doku: http://www.letscontrolit.com/wiki/index ... evelopment

StefanD
Normal user
Posts: 21
Joined: 28 Jan 2017, 20:07

Re: Still bugs in new INA219.ino for quad INA219 support

#6 Post by StefanD » 06 Mar 2017, 19:56

Hi everyone,
I did some others modifications on the code in order to display in the topics from which INA the measurements are performed.
Something like INA 0x41 : voltage : 12.34. I will try to make a pull request via Github if is not too complicated...
Best regards

Post Reply

Who is online

Users browsing this forum: No registered users and 25 guests