ESP Easy Github pull requests

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
Martinus

ESP Easy Github pull requests

#1 Post by Martinus » 20 Oct 2016, 12:00

As we are in the middle of launching a new stable to replace R120, no pull requests will be accepted in the current ESP Easy repository unless they fix a bug.
(and missing features are not considered bugs).

And after the new stable has been released, chances are high that a new repository will be created for future development and the existing repository will remain only for bugfixes on 512k ESP modules.

So please do not create more pull requests on this repository for new features and such.

hvdwolf
Normal user
Posts: 27
Joined: 09 Jun 2016, 12:37

Re: ESP Easy Github pull requests

#2 Post by hvdwolf » 24 Oct 2016, 19:34

Sorry. Hadn't seen this message. Do you want me to remove my pull request?

Edit: I already closed it. I will deliver a new one.

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#3 Post by psy0rz » 13 Feb 2017, 09:54

Wouldn't it be better to just create a 512k branch after the release, and continue development on master as usual?

That way the pullrequests could stay.

A new repository sounds like overkill.
Please support ESPEasy development via Patreon or buy us a coffee.

DeNB3rt
Normal user
Posts: 119
Joined: 15 Dec 2015, 14:07

Re: ESP Easy Github pull requests

#4 Post by DeNB3rt » 13 Feb 2017, 13:03

I don't use the 512K's anymore, so have a go ;)
Located in Belgium, Bruges. Working on a full DIY domoticz setup with ESPEasy.

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#5 Post by psy0rz » 13 Feb 2017, 21:11

What if we create a easy way to enable/disable certain plugins at compile time?

This way its easy to release different binaries: A "normal" version and a stripped-down 512K version that only has a subsection of plugins enabled by default.

The end-users of the 512k version then can also choose to compile their own version with a different set of plugins enabled.

Edwin
Please support ESPEasy development via Patreon or buy us a coffee.

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#6 Post by psy0rz » 13 Feb 2017, 21:23

Now that i think of it: This way we also could handle plugins that are still in "testing" in the playground.

Then we can even release 3 versions: "slim 512k version", "normal" and "normal + all the testing plugins".

Perhaps we cant do that for some special plugins that affect stable code when they are not running. (or plugins that depend on unstable code thats not in mainline yet)

Edwin
Please support ESPEasy development via Patreon or buy us a coffee.

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#7 Post by psy0rz » 17 Feb 2017, 17:09

All these things and more are fixed in https://github.com/psy0rz/ESPEasy-platformio (also binary releases over there)

Edwin
Please support ESPEasy development via Patreon or buy us a coffee.

TD-er
Core team member
Posts: 1618
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: ESP Easy Github pull requests

#8 Post by TD-er » 05 Sep 2017, 00:10

What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.

So perhaps someone can shed some light on the status of pull requests to n00bs like me :)

papperone
Normal user
Posts: 497
Joined: 04 Oct 2016, 23:16

Re: ESP Easy Github pull requests

#9 Post by papperone » 10 Sep 2017, 21:12

TD-er wrote:
05 Sep 2017, 00:10
What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.

So perhaps someone can shed some light on the status of pull requests to n00bs like me :)
+1

Any news? Piling up of pull-req is not helping with who wants to update/enhance what's not yet approved :(

2nd n00b here :lol:
My TINDIE Store where you can find all ESP8266 boards I manufacture --> https://www.tindie.com/stores/GiovanniCas/
My Wiki Project page with self-made PCB/devices --> https://www.letscontrolit.com/wiki/inde ... :Papperone

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#10 Post by psy0rz » 22 Sep 2017, 00:50

i merged a bunch of pull requests. i'll unstick this (very old) topic and create a new one to indicate whats going on.
Please support ESPEasy development via Patreon or buy us a coffee.

psy0rz
Normal user
Posts: 232
Joined: 02 Feb 2017, 12:12

Re: ESP Easy Github pull requests

#11 Post by psy0rz » 22 Sep 2017, 00:53

Oh it seems i cant unstick it. :)
Please support ESPEasy development via Patreon or buy us a coffee.

TD-er
Core team member
Posts: 1618
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: ESP Easy Github pull requests

#12 Post by TD-er » 05 Oct 2017, 21:00

So we're stuck with it? ;)

User avatar
ThomasB
Normal user
Posts: 406
Joined: 17 Jun 2018, 20:41
Location: USA

Re: ESP Easy Github pull requests

#13 Post by ThomasB » 01 May 2019, 23:41

This topic is stale and no longer relevant. I suggest it be removed from the sticky list.

- Thomas

User avatar
grovkillen
Core team member
Posts: 3263
Joined: 19 Jan 2017, 12:56
Location: Hudiksvall, Sweden
Contact:

Re: ESP Easy Github pull requests

#14 Post by grovkillen » 02 May 2019, 05:35

ThomasB wrote:
01 May 2019, 23:41
This topic is stale and no longer relevant. I suggest it be removed from the sticky list.

- Thomas
Done
ESP Easy Flasher [flash tool and wifi setup at flash time]
ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you :idea: :idea: :idea:

Post Reply

Who is online

Users browsing this forum: No registered users and 7 guests