Chicken door and light

[SqUaT]

Hello,

I was trying to create some rules for my chicken.
Switch light on at 6:00 and switch off at sunrise + light on at sunrise and light off at 20:00
Later I would like to implement the door to open and close them automatically.
Additional I would like to toggle the light by pressing a button (key). Each parts of the code work alone.

My idea was to generate dummy variable to hold the state (light on morning, light on evening) and also use always the same code for switch the light, but it dosn't work propperly.

Could somebody tell me, what I'm doing wrong?

Code: Select all

on System#Boot do
    timerSet,1,20
endon

on Rules#Timer=1 do
    if %systm_hm% > 6:00 and %systm_hm% < %sunrise% or  %systm_hm%  > %sunset% and %systime% < 20:00
         GPIO,12,0//Relais
         GPIO,13,0//LED 
    else
		GPIO,12,1//Relais
         GPIO,13,1//LED 
    endif
endon


On Clock#Time=All,6:00 do // every day at 6:00 hours switch on relay on gpio 12
 gpio,12,0
 GPIO,13,0//LED
 endon

//at sunrise time switch light off//set timer1 for 1 hour
On Clock#Time=All,%sunrise% do
//timerSet,2,3600
 GPIO,12,1//Relais/light off
 GPIO,13,1//LED off
 //GPIO,1,0//door up
 endon

//at sunset time switch light on
On Clock#Time=All,%sunset% do
 timerSet,1,3600
 GPIO,12,0//Relais
 GPIO,13,0//LED
 endon

//When Timer1 expires, <action>
On Rules#Timer=1 do
 GPIO,1,0 // close door
 endon

On Clock#Time=All,20:00 do // every day at 20:00 hours switch off relay on gpio 12
 GPIO,12,1//Relais
 GPIO,13,1//LED
 endon
 

[grovkillen]

You have two Rules#Timer=1 which will not work. Only one is allowed.

[SqUaT]

OK, one step before.
Switching light on and of via dummy

EASYESP.GIF (53.56 KiB) Viewed 7008 times

Code: Select all

on System#Boot do
    timerSet,1,10
endon

on Rules#Timer=1 do

if Dummy#Moring=1
 GPIO,13,0
else
//On Dummy#Moring=0 do
 GPIO,13,1
 //TaskValueSet 3, 1, 1
endif
endon

Another test was:

Code: Select all

On Dummy#Moring=1 do
 GPIO,13,0
else
//On Dummy#Moring=0 do
 GPIO,13,1
endon

Or:

Code: Select all

On Dummy#Moring=1 do
 GPIO,13,0
 endon
On Dummy#Moring=0 do
 GPIO,13,1
endon

[Domosapiens]

I see
Moring
instead of
Morning

[SqUaT]

Thanks, but the error exist. The Led is still off.
If I send the Gpio command via http, I get the following error.

Code: Select all

http://IP/control?cmd=GPIO,13,1

Unknown or restricted command!

[grovkillen]

What version?

[SqUaT]

GIT version: mega-20181208

[grovkillen]

Please update to latest, there might be a bug...

[SqUaT]

That helps a bit. The error doesn't appears.

One thing I found was the missing "[]"

Code: Select all

on System#Boot do
 timerSet,1,2
endon

On Rules#Timer=1 do
 if [Dummy#Morning]=1
  //GPIO,13,0
  TaskValueSet,3,1,0
 else
  //GPIO,13,1
  TaskValueSet,3,1,1
 endif
timerSet,1,2
endon

Now the LED will go on an off, but (only by using gpio function), not with the following code.

Code: Select all

On LED#LED=1 do
 if [LED#LED]=1
  GPIO,13,0
 else
  GPIO,13,1
 endif
endon

LED is Task 3 (TaskValueSet,3,...)

[grovkillen]

That helps a bit. The error doesn't appears.

One thing I found was the missing "[]"

Code: Select all

on System#Boot do
 timerSet,1,2
endon

On Rules#Timer=1 do
 if [Dummy#Morning]=1
  //GPIO,13,0
  TaskValueSet,3,1,0
 else
  //GPIO,13,1
  TaskValueSet,3,1,1
 endif
timerSet,1,2
endon

Now the LED will go on an off, but (only by using gpio function), not with the following code.

Code: Select all

On LED#LED=1 do
 if [LED#LED]=1
  GPIO,13,0
 else
  GPIO,13,1
 endif
endon

LED is Task 3 (TaskValueSet,3,...)

Code: Select all

On LED#LED do
 if [LED#LED]=1
  GPIO,13,0
 else
  GPIO,13,1
 endif
endon

I would rename the value to state.

Code: Select all

LED#state

[SqUaT]

Good. Renaming helps.

Now I create the following Code. On manually changes of state "morning" and "evening", the relay and the Led toggle, also on using the button. But the state will not change on time.

I activate ntp and set the location Settings. Additional I set DSP on.

esp_chicken_door_DSP.PNG (16.03 KiB) Viewed 6894 times

Does somebody know, why the time and sunset/sunrise did not set the State properly?

Code: Select all

on System#Boot do
    timerSet,1,20
endon

on Rules#Timer=1 do
 if %systm_hm% > 6:00 and %systm_hm% < %sunrise% //morning - set state to indicate light on
  TaskValueSet 5,1,1
  taskRun,5
 endif
 if %systm_hm%  > %sunset% and %systime% < 20:00 //evening - set state to indicate light on
  TaskValueSet 5,2,1
  taskRun,5
 endif
endon

On Clock#Time=All,6:00 do // every day at 6:00 hours switch on relay on
 TaskValueSet 5,1,1
 taskRun,5
endon


//at sunrise time switch light off//set timer1 for 1 hour
On Clock#Time=All,%sunrise% do
//timerSet,2,3600
 TaskValueSet 5,1,0
 taskRun,5
 endon

//at sunset time switch light on
On Clock#Time=All,%sunset% do
 TaskValueSet 5,2,1
 taskRun,5
 endon


On Clock#Time=All,20:00 do // every day at 20:00 hours switch off relay on gpio 12
 TaskValueSet 5,2,0
 taskRun,5
endon


// morning - relay
on LightState#morning do
  if [LightState#morning]=1
   gpio,12,1
   TaskValueSet 5,2,1
  else
   gpio,12,0
   TaskValueSet 5,2,0
  endif
endon 

// evening - relay
on LightState#evening do
  if [LightState#evening]=1
   gpio,12,1
   TaskValueSet 5,3,1
  else
   gpio,12,0
   TaskValueSet 5,3,0
  endif
endon 

// Button - relay
on button#switch do
  if [button#switch]=1
   gpio,12,1
   TaskValueSet 5,3,1
  else
   gpio,12,0
   TaskValueSet 5,3,0
  endif
 endon 

// LED
on relay#switch do
  if [relay#switch]=1 //change this [relay#switch]=0 for LED off when relay is closed
   gpio,13,0 //or pwm,13,700
  else
   gpio,13,1 //or pwm,13,10
  endif
 endon 

[Domosapiens]

I'm not sure what you are doing but:
- Task LED on GPIO 13 is defined as Task 3 as input
- In the Rule you control GPIO 13 as output

- GPIO-0 is a special one! Has a Pull-up on most boards.
- That means your switch must be active Low (at least ... high at boot!)
- Use GPIO-14 instead, just to make sure

[SqUaT]

I update to Version mega-20181220 and delete all devices which aren't in use.
But today at the evening, the LightState does not go to 1. after seting it manually, one Minute later it was switching back to 0 and the light go off.

How can I see the variable %systm_hm% to verify the correct time?

I have also test to delete the %sunrise% and %sunset% to fix times (8:30 and 16:00, but it didn't work.

The switch (button), the led and the relay works now correct.

Code: Select all

on System#Boot do
    timerSet,1,20
endon

on Rules#Timer=1 do
 if %systm_hm% > 6:00 and %systm_hm% < %sunrise% //morning - set state to indicate light on
  TaskValueSet 3,1,1
  taskRun,3
 endif
 if %systm_hm% > %sunset% and %systime% < 20:00 //evening - set state to indicate light on
  TaskValueSet 3,2,1
  taskRun,3
 endif
endon

On Clock#Time=All,6:00 do // every day at 6:00 hours switch on relay on
 TaskValueSet 3,1,1
 taskRun,3
endon


//at sunrise time switch light off//set timer1 for 1 hour
On Clock#Time=All,%sunrise% do
 TaskValueSet 3,1,0
 taskRun,3
 endon

//at sunset time switch light on
On Clock#Time=All,%sunset% do
 TaskValueSet 3,2,1
 taskRun,3
 endon


On Clock#Time=All,20:00 do // every day at 20:00 hours switch off relay on gpio 12
 TaskValueSet 3,2,0
 taskRun,3
 endon

// morning - relay
on LightState#morning do
  if [LightState#morning]=1
   gpio,12,1
  else
   gpio,12,0
  endif
endon

// evening - relay
on LightState#evening do
  if [LightState#evening]=1
   gpio,12,1
  else
   gpio,12,0
  endif
endon

// Button - relay
on button#switch do
  if [button#switch]=1
   gpio,12,1
  else
   gpio,12,0
  endif
 endon

// LED
on relay#switch do
  if [relay#switch]=1 //change this [relay#switch]=0 for LED off when relay is closed
   gpio,13,0 //or pwm,13,700
  else
   gpio,13,1 //or pwm,13,10
  endif
 endon 

[grovkillen]

In tools you have the system variables page.

[SqUaT]

OK, the system variable are in the same format and nearly the same time as written before (8:31 an 15:50).

Could somebody find an error in the code, why the LightState was set to 0 today at 17:30?