Rules#Timer and eventvalue

[Micha_he]

Is it possible to use one 'Rules#Timer' trigger and use the timer# in %eventvalue% ?

I've 6 partially parallel running timer, which mostly execute the same actions.

[TD-er]

I've 6 partially parallel running timer, which mostly execute the same actions.

You can create your own events and fire them from rules.
Consider it like calling a function in normal programming languages.
So if you place the 'same actions' in a separate event block and just fire that event, then you may be able to reduce code duplication.

[Micha_he]

Example (current):

Code: Select all

On Rules#Timer=1 do
  Event,CloseValve=1
  LogEntry,ValveClose 1
  Let,1,0
EndOn

On Rules#Timer=2 do
  Event,CloseValve=2
  LogEntry,ValveClose 2
  Let,2,0
EndOn

On Rules#Timer=3 do
  Event,CloseValve=3
  LogEntry,ValveClose 3
  Let,3,0
EndOn

My idea:

Code: Select all

On Rules#Timer do
  Event,CloseValve=%eventvalue%
  LogEntry,ValveClose %eventvalue%
  Let,%eventvalue%,0
EndOn

With 6 timer I could save some rule-code

[grovkillen]

Your wish is a good feature request. I mean why wouldn't the timer event also have an event value that could be used?

[TD-er]

I'm a bit surprised this isn't available as %eventvalue%

[Micha_he]

@TD-er: You think it should work?

[grovkillen]

Yes it should work that way.

[Micha_he]

I'll change my rule this evening and report the result here...

[grovkillen]

I just tested this on current code base and it worked just fine.

Code: Select all

On TESTEVENT Do
 logentry,%eventvalue%
EndOn

On Rules#Timer DO
  Event,TESTEVENT=%eventvalue%
Endon

[Micha_he]

Nice... The feature is added, before I asked for it

[grovkillen]

I've been using it like that but for custom events, not the timer event. I thought you had tested it and found a bug/missing feature.

[grovkillen]

You can do it like this too:

Code: Select all

On TEST1EVENT Do
 logentry,HELLO
EndOn

On Rules#Timer Do
  Event,TEST%eventvalue%EVENT
EndOn

So you could send it to different events by name.

[grovkillen]

Or this one:

Code: Select all

On TESTEVENT Do
 logentry,%eventvalue%
EndOn

On Rules#Timer Do
  Let,%eventvalue%,[INT#%eventvalue%#!Z]
  Event,TESTEVENT=[INT#%eventvalue%]
EndOn

Every other run the corresponding variable will be 1 and 0 (alternating).

[Micha_he]

Works great for me too. ~600byte rule-code saved

[TD-er]

Works great for me too. ~600byte rule-code saved

That's always nice to see some code duplication was prevented