I have a couple of proposals for the LCD plugin:
1. I noticed that you cannot display the comma character ','. Or text which contains commas (eg. "text,with,commas")
The software, when parsing the command, looks for the last comma and displays the text after it. In file _P012_LCD.ino, we can replace the lines:
Code: Select all
argIndex = string.lastIndexOf(',');
tmpString = string.substring(argIndex + 1);
Code: Select all
tmpString = string.substring(string.indexOf(',') + 1);
for (int i = 1; i <= 2; i++){
argIndex = tmpString.indexOf(',');
tmpString = tmpString.substring(argIndex + 1);
}
2. Then, I also noticed that no checks are made if there is no string to display. Should there be an error indication to the user?
3. What if we have a new LCD command, which displays text on the last line (truncating if it doesn't fit), and moves the existing text one line up (or vice versa: pushing text down). Like appending. Would that be something useful?
Regards