SD CARD

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

SD CARD

#1 Post by surfa2000 » 15 Oct 2019, 21:51

Hi I hope someone may be able to help.

I am looking to compile the firmware with SD card support.

Whenever I try with the #define FEATURE_SD within the ESPEasy-Globals.h uncommented it fails to build with lots of errors such as

src\src/Commands/MQTT.h:10:5: error: cannot convert 'const char*' to 'const __FlashStringHelper*' for argument '2' to 'String Command_GetORSetBo
ol(EventStruct*, const __FlashStringHelper*, const char*, bool*, int)'

I woulc be grateful if someone could also try to see if it's an issue with my environment or something else?

Thanks

kiemtienspeed
Normal user
Posts: 1
Joined: 16 Oct 2019, 06:59

Re: SD CARD

#2 Post by kiemtienspeed » 16 Oct 2019, 07:33

I have encountered the same situation as you and have not had a fix. Maybe I'll buy another SD

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#3 Post by TD-er » 16 Oct 2019, 09:47

kiemtienspeed wrote:
16 Oct 2019, 07:33
I have encountered the same situation as you and have not had a fix. Maybe I'll buy another SD
Just curious.
The original post is about compiler issues and you are thinking about using another SD card?
What is the idea behing it?

@surfa2000.
I will have a look and see if I can test whether there is a problem in building with the FEATURE_SD flag enabled.
I have to admit, I have not compiled it using that flag for a while. (also not tested it myself)

surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#4 Post by surfa2000 » 17 Oct 2019, 18:25

TD-er wrote:
16 Oct 2019, 09:47

@surfa2000.
I will have a look and see if I can test whether there is a problem in building with the FEATURE_SD flag enabled.
I have to admit, I have not compiled it using that flag for a while. (also not tested it myself)
Hi TD-er thanks for taking the time to investigate the potential issue. Really appreciate your time on this.

surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#5 Post by surfa2000 » 24 Oct 2019, 21:33

Hi - has anyone else had issues compiling with the SD card featur eneabled. I don''t know what I am missing. Thanks

arnemauer
Normal user
Posts: 1
Joined: 20 Sep 2019, 19:39

Re: SD CARD

#6 Post by arnemauer » 26 Oct 2019, 17:28

Same problem here :( is there already a fix?

I tried to compile 03102019 and 03092019 but both fails to compile.

surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#7 Post by surfa2000 » 29 Oct 2019, 21:33

Thanks for the confirmation. What is the best way to request a fix? Is it via github although I am not familiar with doing it there.

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#8 Post by TD-er » 29 Oct 2019, 21:50

surfa2000 wrote:
29 Oct 2019, 21:33
Thanks for the confirmation. What is the best way to request a fix? Is it via github although I am not familiar with doing it there.
I am already working on it, but the fix is a lot bigger than I expected it would be.

surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#9 Post by surfa2000 » 31 Oct 2019, 21:40

TD-er wrote:
29 Oct 2019, 21:50
I am already working on it, but the fix is a lot bigger than I expected it would be.
Sorry to hear it's turned into a bigger fix than anticipated. Great to hear you are working on it and appreciate the update.

Droscovi
Normal user
Posts: 2
Joined: 24 Nov 2019, 19:23

Re: SD CARD

#10 Post by Droscovi » 24 Nov 2019, 19:31

I have been following the SD compile issue on Github and noticed it appears to be solved?

"SD Card Value Logger Enable #2700" and "SDFS/SD make F() strings appear in RODATA, not flash #6767" issues have made some great progress. Release mega-20191116 release notes include "[SD] Allow to compile with FEATURE_SD defined".

Can were now compile with SD? I have tried to uncomment some SD strings and include some SD libraries based on the developments on Github but I still can't seem to get a successful compile.

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#11 Post by TD-er » 24 Nov 2019, 21:07

I have not tried since that fix has been merged.
Not sure if all issues are now solved and for sure I have not tested the code for it :)

surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#12 Post by surfa2000 » 04 Dec 2019, 21:28

Thanks for the hard work on this. Unfortuantly doesn't compile for me either with similar issue with SD card libraries. Is there anything that we can try to make compilation sucessful?

Thanks again

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#13 Post by TD-er » 04 Dec 2019, 21:43


surfa2000
Normal user
Posts: 8
Joined: 28 Sep 2019, 18:53

Re: SD CARD

#14 Post by surfa2000 » 05 Dec 2019, 21:04

TD-er wrote:
04 Dec 2019, 21:43
You can try to build this PR:
https://github.com/letscontrolit/ESPEasy/pull/2798
Hi TD-er - thanks for this appreciate your help. That has gone through the build process. I look forward to testing. Thanks again!

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#15 Post by TD-er » 05 Dec 2019, 21:49

I also prepared a test build for it: https://www.dropbox.com/s/oajoktd46u364 ... 8.zip?dl=0

Droscovi
Normal user
Posts: 2
Joined: 24 Nov 2019, 19:23

Re: SD CARD

#16 Post by Droscovi » 19 Dec 2019, 06:23

I just managed to compile and upload the SD test build. It works! VALUES.CSV is writing from my devices to the SD card. I really appreciate the effort put into making this work as it is hugely important for my project :D . Going forward, is there any way to control what (and how) is written to the SD card? Things like changing the filename or how the string is written (to include no date or less data ect.)

User avatar
grovkillen
Core team member
Posts: 3612
Joined: 19 Jan 2017, 12:56
Location: Hudiksvall, Sweden
Contact:

Re: SD CARD

#17 Post by grovkillen » 19 Dec 2019, 09:38

That would be something for the future, but SD card is something we do want to have better support for. We're not that rich on time at the moment though. I crashed mentally some month ago and haven't been able to work since = no income. On the flip side of that is that I could spend some more time on the GUI update (I don't feel stressed about working on the project, compared to working on others projects). Gijs is moving to temporary housing since his house is being demolished due to man made earth quakes (fracking) taking place under his neighborhood. So we're really short on funds and time :?

But we feel that 2020 is the year where it all turns.
ESP Easy Flasher [flash tool and wifi setup at flash time]
ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you :idea: :idea: :idea:

TD-er
Core team member
Posts: 2889
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: SD CARD

#18 Post by TD-er » 19 Dec 2019, 14:41

earth quakes (fracking)
Not fracking, but "normal" gas extraction for the last 6 or 7 decades.
But that has not much to do with SD card support :)

Right now, the SD card support was a bit neglected, so we should indeed add more features to that part of the code.
Maybe also have a look at how the data is written to SD, as that may need some ease in writing or else you may destroy those cards in no-time.

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 19 guests