on Clock#Time=All,**:00 do

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
User avatar
Andrew Mamohin
Normal user
Posts: 95
Joined: 12 Jun 2020, 08:30
Location: Belarus, Gomel
Contact:

on Clock#Time=All,**:00 do

#1 Post by Andrew Mamohin » 26 Mar 2023, 11:13

How can I make an event that runs every hour at exactly 0 minutes?
If I put "on Clock#Time=All,**:00 do", then it throws an error: "timeStringToSeconds: '0' --> invalid".
The same happens if "Clock#Time=All,**:0".
If I put "on Clock#Time=All,**:01 do", then everything turns out well.
Andy.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: on Clock#Time=All,**:00 do

#2 Post by TD-er » 26 Mar 2023, 11:22

Sounds like a bug....

As a work-around, you could start a timer at :59 and act on the event triggered by this timer.
Just until this bug is fixed. (Related GitHub issue)

User avatar
Andrew Mamohin
Normal user
Posts: 95
Joined: 12 Jun 2020, 08:30
Location: Belarus, Gomel
Contact:

Re: on Clock#Time=All,**:00 do

#3 Post by Andrew Mamohin » 26 Mar 2023, 11:28

TD-er wrote: 26 Mar 2023, 11:22 As a work-around, you could start a timer at :59
Thanks for the answer! For now, I'll set the event to 01, it's not so critical. I just wanted to show a bug.
Andy.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: on Clock#Time=All,**:00 do

#4 Post by TD-er » 27 Mar 2023, 12:39

I just looked into this and I find it really strange this error is occuring now.
The only changes made to it (2 years ago) is to change `byte` to `uint8_t`
The latest change before that was 3 year ago.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: on Clock#Time=All,**:00 do

#5 Post by TD-er » 27 Mar 2023, 13:25

Hmm, looks like the getNumerical function is acting up here....

May have to look at it later this evening.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: on Clock#Time=All,**:00 do

#6 Post by TD-er » 27 Mar 2023, 17:35

Can you test the test build for this PR (when it is ready) ?
https://github.com/letscontrolit/ESPEasy/pull/4573

User avatar
Andrew Mamohin
Normal user
Posts: 95
Joined: 12 Jun 2020, 08:30
Location: Belarus, Gomel
Contact:

Re: on Clock#Time=All,**:00 do

#7 Post by Andrew Mamohin » 27 Mar 2023, 18:10

TD-er wrote: 27 Mar 2023, 17:35 Can you test the test build for this PR (when it is ready) ?
With pleasure. Where can I get it?
Andy.

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: on Clock#Time=All,**:00 do

#8 Post by Ath » 27 Mar 2023, 19:12

Andrew Mamohin wrote: 27 Mar 2023, 18:10 With pleasure. Where can I get it?
https://github.com/letscontrolit/ESPEas ... 4533803433
/Ton (PayPal.me)

User avatar
Andrew Mamohin
Normal user
Posts: 95
Joined: 12 Jun 2020, 08:30
Location: Belarus, Gomel
Contact:

Re: on Clock#Time=All,**:00 do

#9 Post by Andrew Mamohin » 28 Mar 2023, 07:50

Everything works without errors. Thank you very much!
Andy.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: on Clock#Time=All,**:00 do

#10 Post by TD-er » 28 Mar 2023, 08:49

Great!

This was a bug in our numerical parser function, so it may also fix other issues where numbers are parsed.

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: on Clock#Time=All,**:00 do

#11 Post by Ath » 31 Mar 2023, 18:48

Andrew Mamohin wrote: 28 Mar 2023, 07:50
Everything works without errors. Thank you very much!
The fixes have been merged into 'mega'.
/Ton (PayPal.me)

Post Reply

Who is online

Users browsing this forum: No registered users and 31 guests