Page 1 of 1

ESP Easy Github pull requests

Posted: 20 Oct 2016, 12:00
by Martinus
As we are in the middle of launching a new stable to replace R120, no pull requests will be accepted in the current ESP Easy repository unless they fix a bug.
(and missing features are not considered bugs).

And after the new stable has been released, chances are high that a new repository will be created for future development and the existing repository will remain only for bugfixes on 512k ESP modules.

So please do not create more pull requests on this repository for new features and such.

Re: ESP Easy Github pull requests

Posted: 24 Oct 2016, 19:34
by hvdwolf
Sorry. Hadn't seen this message. Do you want me to remove my pull request?

Edit: I already closed it. I will deliver a new one.

Re: ESP Easy Github pull requests

Posted: 13 Feb 2017, 09:54
by psy0rz
Wouldn't it be better to just create a 512k branch after the release, and continue development on master as usual?

That way the pullrequests could stay.

A new repository sounds like overkill.

Re: ESP Easy Github pull requests

Posted: 13 Feb 2017, 13:03
by DeNB3rt
I don't use the 512K's anymore, so have a go ;)

Re: ESP Easy Github pull requests

Posted: 13 Feb 2017, 21:11
by psy0rz
What if we create a easy way to enable/disable certain plugins at compile time?

This way its easy to release different binaries: A "normal" version and a stripped-down 512K version that only has a subsection of plugins enabled by default.

The end-users of the 512k version then can also choose to compile their own version with a different set of plugins enabled.

Edwin

Re: ESP Easy Github pull requests

Posted: 13 Feb 2017, 21:23
by psy0rz
Now that i think of it: This way we also could handle plugins that are still in "testing" in the playground.

Then we can even release 3 versions: "slim 512k version", "normal" and "normal + all the testing plugins".

Perhaps we cant do that for some special plugins that affect stable code when they are not running. (or plugins that depend on unstable code thats not in mainline yet)

Edwin

Re: ESP Easy Github pull requests

Posted: 17 Feb 2017, 17:09
by psy0rz
All these things and more are fixed in https://github.com/psy0rz/ESPEasy-platformio (also binary releases over there)

Edwin

Re: ESP Easy Github pull requests

Posted: 05 Sep 2017, 00:10
by TD-er
What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.

So perhaps someone can shed some light on the status of pull requests to n00bs like me :)

Re: ESP Easy Github pull requests

Posted: 10 Sep 2017, 21:12
by papperone
TD-er wrote: 05 Sep 2017, 00:10 What is the current status of processing/merging pull requests?
The pull requests are piling up here: https://github.com/letscontrolit/ESPEasy/pulls
Looking at myself, I do not know when (if?) they will be processed and am somewhat waiting to make some changes until the requests of others are processed because otherwise it is very hard to merge.

So perhaps someone can shed some light on the status of pull requests to n00bs like me :)
+1

Any news? Piling up of pull-req is not helping with who wants to update/enhance what's not yet approved :(

2nd n00b here :lol:

Re: ESP Easy Github pull requests

Posted: 22 Sep 2017, 00:50
by psy0rz
i merged a bunch of pull requests. i'll unstick this (very old) topic and create a new one to indicate whats going on.

Re: ESP Easy Github pull requests

Posted: 22 Sep 2017, 00:53
by psy0rz
Oh it seems i cant unstick it. :)

Re: ESP Easy Github pull requests

Posted: 05 Oct 2017, 21:00
by TD-er
So we're stuck with it? ;)

Re: ESP Easy Github pull requests

Posted: 01 May 2019, 23:41
by ThomasB
This topic is stale and no longer relevant. I suggest it be removed from the sticky list.

- Thomas

Re: ESP Easy Github pull requests

Posted: 02 May 2019, 05:35
by grovkillen
ThomasB wrote: 01 May 2019, 23:41 This topic is stale and no longer relevant. I suggest it be removed from the sticky list.

- Thomas
Done