change rules after mega-20191130 ?

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
adval40
Normal user
Posts: 26
Joined: 04 Apr 2017, 23:14

change rules after mega-20191130 ?

#1 Post by adval40 » 18 Dec 2019, 22:38

in software version mega-20191104 the following works perfectly
in software version mega-20191130 the following does not work anymore
do I have to change anything in the rules settings ?
I cannot see the temperature on lcd
I can't put uppercase in lcd it's shows only lowercase characters

Code: Select all

On System#Boot do
 gpio,2,0
 timerSet,1,10
endon
    
On Rules#Timer=1 do 
 LCD,3,1, temperatuur [woonkamer#temperature]
timerSet,1,10
endon

adval40
Normal user
Posts: 26
Joined: 04 Apr 2017, 23:14

Re: change rules after mega-20191130 ?

#2 Post by adval40 » 19 Dec 2019, 00:48

one problem is solved

LCD,3,1, temperatuur [woonkamer#temperature]
must be
LCD,3,1, 'temperatuur [woonkamer#temperature]'


but
LCD,3,1, 'TEMPERATUUR [woonkamer#temperature]'

shows temperatuur 23.0 on display
I cannot show capital characters

TD-er
Core team member
Posts: 2045
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: change rules after mega-20191130 ?

#3 Post by TD-er » 19 Dec 2019, 14:28

Indeed the rules parameter parsing has been changed.
So now you need to wrap parameters in quotes if they contain a space or comma.

The parameters should be given to a plugin without change of case, so if the LCD command does not keep the case in its parameter, then that's a bug.

adval40
Normal user
Posts: 26
Joined: 04 Apr 2017, 23:14

Re: change rules after mega-20191130 ?

#4 Post by adval40 » 19 Dec 2019, 18:23

LCD,3,1, 'TEMPERATUUR [woonkamer#temperature]'

is this rule correct ?


but the output is

temperatuur 23.8

is this a bug ?

User avatar
grovkillen
Core team member
Posts: 3417
Joined: 19 Jan 2017, 12:56
Location: Hudiksvall, Sweden
Contact:

Re: change rules after mega-20191130 ?

#5 Post by grovkillen » 19 Dec 2019, 18:38

Yes that's a bug. @TD-er: seems like we lower cased the output and not the original string.
ESP Easy Flasher [flash tool and wifi setup at flash time]
ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you :idea: :idea: :idea:

User avatar
ThomasB
Normal user
Posts: 511
Joined: 17 Jun 2018, 20:41
Location: USA

Re: change rules after mega-20191130 ?

#6 Post by ThomasB » 19 Dec 2019, 19:06

The bug is due to the introduction of parseString() in the LCD plugins (P036_FRAMEOLED & P012_LCD) a couple weeks ago. This function does a toLowerCase() on the arg strings.
- Thomas

TD-er
Core team member
Posts: 2045
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: change rules after mega-20191130 ?

#7 Post by TD-er » 19 Dec 2019, 21:40

ThomasB wrote:
19 Dec 2019, 19:06
The bug is due to the introduction of parseString() in the LCD plugins (P036_FRAMEOLED & P012_LCD) a couple weeks ago. This function does a toLowerCase() on the arg strings.
- Thomas
Thanks, will have a look at this.

TD-er
Core team member
Posts: 2045
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: change rules after mega-20191130 ?

#8 Post by TD-er » 19 Dec 2019, 22:16


Post Reply

Who is online

Users browsing this forum: No registered users and 17 guests