New plugin for DDS238-1

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
jm_araujo
Normal user
Posts: 2
Joined: 11 Feb 2020, 13:39

New plugin for DDS238-1

#1 Post by jm_araujo » 11 Feb 2020, 13:55

Hi,
I'm developing a new plugin for the DDS238-1 ZN Energy Meter with MODBUS interface, found cheaply (under 20€) on Aliexpress and other similar sites.

I'm mostly done finishing testing, and would like to share it with the community, but I don't understand how new plugin numbers are attributed in the ESPEasyPluginPlayground. Do I have to contact someone, or just pick one? I see a lot of gaps in the numbering of the plugins in the playground, can I pick a low one in a gap ( like number 136 seems to not have been used), or do I go for the end: I see a 251 in the pull requests, so I should pick 252?

I searched and couldn't find an answer, so I've decided to ask here.

Thank you.

User avatar
grovkillen
Core team member
Posts: 3439
Joined: 19 Jan 2017, 12:56
Location: Hudiksvall, Sweden
Contact:

Re: New plugin for DDS238-1

#2 Post by grovkillen » 11 Feb 2020, 13:58

The playground is a free for all. Pick whatever number you feel like.

If you plan on applying it to the official repo you will be assigned the next available number (91 I think).
ESP Easy Flasher [flash tool and wifi setup at flash time]
ESP Easy Webdumper [easy screendumping of your units]
ESP Easy Netscan [find units]
Official shop: https://firstbyte.shop/
Sponsor ESP Easy, we need you :idea: :idea: :idea:

TD-er
Core team member
Posts: 2117
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: New plugin for DDS238-1

#3 Post by TD-er » 11 Feb 2020, 14:02

For the playground it doesn't really matter a lot, as people always make their own builds based on that code.
But for the main repository, I will just assign a new number, based on the existing used numbers + the open pull requests.

For the playground we usually use > 127, as that was probably once the "oh we will never reach that" value and a nice split of the 8 bit range.
But I think we should soon also look into using larger int values for the plugin ID. (which may be quite hard to do as it will also break settings)
For now, pick a free one between 128 and 255

jm_araujo
Normal user
Posts: 2
Joined: 11 Feb 2020, 13:39

Re: New plugin for DDS238-1

#4 Post by jm_araujo » 12 Feb 2020, 00:45

Thank you for your prompt replies,
Just finished my testing and created a pull request, numbered it 224.
I hope it is useful for someone else.

Post Reply

Who is online

Users browsing this forum: Google [Bot] and 14 guests