no dashboard.esp in 20221105 release

Moderators: grovkillen, Stuntteam, TD-er

Post Reply
Message
Author
User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

no dashboard.esp in 20221105 release

#1 Post by chromo23 » 06 Nov 2022, 09:22

@TD-er: by chance i have noticed that the dashboard.esp is missing in the latest build.
Is this intentional?

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#2 Post by TD-er » 06 Nov 2022, 12:19

This is for sure not intentional.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#3 Post by TD-er » 09 Nov 2022, 09:41

Just to be sure... what is no longer working?
I was just looking into the bug when serving the favicon.ico file, so I'm now looking into this part of the code.
But I don't really get what might be wrong, so please explain.

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#4 Post by chromo23 » 09 Nov 2022, 18:36

Ohh i missed your post...
Bildschirmfoto 2022-11-09 um 18.36.16.png
Bildschirmfoto 2022-11-09 um 18.36.16.png (85.33 KiB) Viewed 4701 times

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#5 Post by TD-er » 09 Nov 2022, 21:23

What build are you using?
The exact binary name

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#6 Post by chromo23 » 10 Nov 2022, 00:05

ESP_Easy_mega_20221017_normal_ESP8266_4M1M

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: no dashboard.esp in 20221105 release

#7 Post by Ath » 10 Nov 2022, 11:48

I'm not sure a default dashboard.esp was ever included? It has to be uploaded manually to the unit...
/Ton (PayPal.me)

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#8 Post by TD-er » 10 Nov 2022, 11:51

I think he -of all people here- probably does do this as he's right now probably the most experienced "dashboard.esp" user out there ;)

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#9 Post by chromo23 » 10 Nov 2022, 14:00

Ath wrote: 10 Nov 2022, 11:48 I'm not sure a default dashboard.esp was ever included? It has to be uploaded manually to the unit...
As long as i am using ESPeasy there was always a "standard" dashboard.esp in every build (i ever used) included without the need to upload anything.
TD-er wrote: 10 Nov 2022, 11:51 I think he -of all people here- probably does do this as he's right now probably the most experienced "dashboard.esp" user out there ;)

That's meant ironically, isn't it? Dashboard.esp was the reason to create easyfetch, as i was never quite happy with it... :)

Edit: The question now could be: Why he -of all people here- notice the missing dashboard.esp when he ist using exclusively his own dashboard.... :D

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#10 Post by TD-er » 10 Nov 2022, 14:41

Hmm the "dashboard.esp" default handler may have been broken indeed.
To be honest, I also thought you had to upload some file.
I will look into the history of the file handling this code to see where I might have messed up.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: no dashboard.esp in 20221105 release

#11 Post by TD-er » 10 Nov 2022, 14:51

Old:
https://github.com/letscontrolit/ESPEas ... pp#L79-L83

New:
https://github.com/letscontrolit/ESPEas ... #L234-L243

So it appears I did indeed mess up here.
The call to handle the custom page used to be before the path was checked to actually exist.
Now it is after it checked whether the file exists.

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#12 Post by chromo23 » 10 Nov 2022, 15:14

if it were up to me you could remove the integrated dashboard.esp completely and leave only the manual upload option...

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: no dashboard.esp in 20221105 release

#13 Post by Ath » 10 Nov 2022, 15:46

Removing features from a (quite) widely used software is always a challenge, that would need at least a *very* easy migration path (and IMHO EasyFetch, though it might be easy, is not *very* easy, but maybe that's because of my limited use of it).
/Ton (PayPal.me)

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#14 Post by chromo23 » 10 Nov 2022, 16:46

Easyfetch is definitely not easy in use and would not be an alternative for the dashboard.esp
But i question the usefullness of dashboard.esp.
It offers an overview of your devices which can also be found on the devices page and you can switch between nodes which can be found also on the main page.... its a bit of a redundancy which also doesn’t look as good as the data on the corresponding pages....
Last edited by chromo23 on 10 Nov 2022, 18:41, edited 1 time in total.

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#15 Post by chromo23 » 10 Nov 2022, 18:33

Maybe we could polish the whole thing up a bit....

To be honest, it looks a bit anachronistic compared to the rest of ESPeasy, euphemistically speaking.
Bildschirmfoto 2022-11-10 um 18.28.43.png
Bildschirmfoto 2022-11-10 um 18.28.43.png (59.63 KiB) Viewed 4605 times
Edit: and as far as i remember you have to manually refresh it to update the values

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#16 Post by chromo23 » 10 Nov 2022, 19:15

Here a simple mockup with the things we already have. Basically i left out the unnecessary columns....
So we could make a bit nicer dashboard.esp
Bildschirmfoto 2022-11-10 um 19.10.57.png
Bildschirmfoto 2022-11-10 um 19.10.57.png (65.77 KiB) Viewed 4594 times
Bildschirmfoto 2022-11-10 um 19.07.40.png
Bildschirmfoto 2022-11-10 um 19.07.40.png (179.79 KiB) Viewed 4594 times

User avatar
budman1758
Normal user
Posts: 301
Joined: 15 Apr 2017, 05:13
Location: Riverside CA USA

Re: no dashboard.esp in 20221105 release

#17 Post by budman1758 » 12 Nov 2022, 19:53

I also noticed there is no dark mode option in the "ESP_Easy_mega_20221105_collection_A_ESP8266_4M1M.bin". Was looking forward to that for my keypad unit upgrade. Need Keypad - HT16K33 and RFID - PN532 in the same build. :( :(
"The glass is twice as big as it needs to be".

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#18 Post by chromo23 » 12 Nov 2022, 20:22

No dark mode at all?

Edit: Did you activated it under tools/advanced?
Bildschirmfoto 2022-11-12 um 20.23.11.png
Bildschirmfoto 2022-11-12 um 20.23.11.png (32.89 KiB) Viewed 4476 times
Edit2: You are right, no option there

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: no dashboard.esp in 20221105 release

#19 Post by Ath » 12 Nov 2022, 20:31

There is this code in define_plugin_sets.h:

Code: Select all

  ...
  #ifdef LIMIT_BUILD_SIZE
    #define FEATURE_AUTO_DARK_MODE            0
  #else
  ...
And the Collection builds all have LIMIT_BUILD_SIZE set...
/Ton (PayPal.me)

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#20 Post by chromo23 » 12 Nov 2022, 20:43

@budman1758 are you able to make your own build or do you need one?
and this is actually not the right thread for this since it is about the missing dashboard.esp as the title states

User avatar
budman1758
Normal user
Posts: 301
Joined: 15 Apr 2017, 05:13
Location: Riverside CA USA

Re: no dashboard.esp in 20221105 release

#21 Post by budman1758 » 13 Nov 2022, 02:09

chromo23 wrote: 12 Nov 2022, 20:43 @budman1758 are you able to make your own build or do you need one?
I'm not set up to make my own builds yet. Did'nt mean to hijack the thread. The option to enable the dark mode is not on the advanced settings page.
"The glass is twice as big as it needs to be".

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#22 Post by chromo23 » 13 Nov 2022, 10:57

@budman1758 here ist you freshly baked morning build. Enjoy

User avatar
budman1758
Normal user
Posts: 301
Joined: 15 Apr 2017, 05:13
Location: Riverside CA USA

Re: no dashboard.esp in 20221105 release

#23 Post by budman1758 » 13 Nov 2022, 20:21

chromo23 wrote: 13 Nov 2022, 10:57 @budman1758 here ist you freshly baked morning build. Enjoy
Thanks a bunch!! Looks great. Methinks the dark mode should be standard equipment on all builds. :D :D
"The glass is twice as big as it needs to be".

Bluesea
New user
Posts: 5
Joined: 16 Jun 2020, 15:26
Location: Switzerland

Re: no dashboard.esp in 20221105 release

#24 Post by Bluesea » 30 Apr 2023, 19:51

Hello

Sorry to bring this old topic on top. I still missing the dashboard on the latest release ESP_Easy_mega_20230409_normal_ESP8266_4M1M.
Is there a fix ongoing or it stays as it is?
Is there a workaround besides stay on the old releases?

User avatar
Ath
Normal user
Posts: 3416
Joined: 10 Jun 2018, 12:06
Location: NL

Re: no dashboard.esp in 20221105 release

#25 Post by Ath » 30 Apr 2023, 20:36

Bluesea wrote: 30 Apr 2023, 19:51 Is there a fix ongoing or it stays as it is?
Is there a workaround besides stay on the old releases?
I've just created a pull request (PR) on Github (#4637) to fix this bug.
You can download a build of that code from this Actions run, once it's ready. You will need to be logged in to your Github account to be able to download, you can create such account for free if you don't have one yet.

Please report your findings here or in the PR.

NB: There is no workaround, unfortunately, but the fix is small, so will probably be merged soon.
/Ton (PayPal.me)

Bluesea
New user
Posts: 5
Joined: 16 Jun 2020, 15:26
Location: Switzerland

Re: no dashboard.esp in 20221105 release

#26 Post by Bluesea » 01 May 2023, 12:40

Thank you very much! Dashboard looks good again. Including Dark Mode. Cool!
I use that function for a cheap website dashboard over all sensors.
Attachments
dashboard.jpg
dashboard.jpg (389.15 KiB) Viewed 3022 times

User avatar
chromo23
Normal user
Posts: 821
Joined: 10 Sep 2020, 16:02
Location: germany

Re: no dashboard.esp in 20221105 release

#27 Post by chromo23 » 02 May 2023, 10:32

Bluesea wrote: 01 May 2023, 12:40 I use that function for a cheap website dashboard over all sensors.
If you want a more modern look of your dashboard you can also try easyfetch. (link is in my signature)
Just download the "fetch.html.gz" (or if you want to have it as the root page download "index.htm.gz") and upload it on one (it only needs to run on one device) of your devices (/tools -> filebrowser).
Open the easyfetch : <ESPeasy-IP>/fetcht.hml.gz (Or if you uploaded "index.htm.gz" just enter the ip)

Post Reply

Who is online

Users browsing this forum: No registered users and 21 guests