on Clock#Time=All,**:00 do

Message

Andrew Mamohin · #1 Post by **Andrew Mamohin** » 26 Mar 2023, 11:13

How can I make an event that runs every hour at exactly 0 minutes?
If I put "on Clock#Time=All,**:00 do", then it throws an error: "timeStringToSeconds: '0' --> invalid".
The same happens if "Clock#Time=All,**:0".
If I put "on Clock#Time=All,**:01 do", then everything turns out well.

TD-er · #2 Post by **TD-er** » 26 Mar 2023, 11:22

Sounds like a bug....

As a work-around, you could start a timer at :59 and act on the event triggered by this timer.
Just until this bug is fixed. (Related GitHub issue)

Andrew Mamohin · #3 Post by **Andrew Mamohin** » 26 Mar 2023, 11:28

TD-er wrote: ↑26 Mar 2023, 11:22 As a work-around, you could start a timer at :59

Thanks for the answer! For now, I'll set the event to 01, it's not so critical. I just wanted to show a bug.

TD-er · #4 Post by **TD-er** » 27 Mar 2023, 12:39

I just looked into this and I find it really strange this error is occuring now.
The only changes made to it (2 years ago) is to change `byte` to `uint8_t`
The latest change before that was 3 year ago.

TD-er · #5 Post by **TD-er** » 27 Mar 2023, 13:25

Hmm, looks like the getNumerical function is acting up here....

May have to look at it later this evening.

TD-er · #6 Post by **TD-er** » 27 Mar 2023, 17:35

Can you test the test build for this PR (when it is ready) ?
https://github.com/letscontrolit/ESPEasy/pull/4573

Andrew Mamohin · #7 Post by **Andrew Mamohin** » 27 Mar 2023, 18:10

TD-er wrote: ↑27 Mar 2023, 17:35 Can you test the test build for this PR (when it is ready) ?

With pleasure. Where can I get it?

Ath · #8 Post by **Ath** » 27 Mar 2023, 19:12

Andrew Mamohin wrote: ↑27 Mar 2023, 18:10 With pleasure. Where can I get it?

https://github.com/letscontrolit/ESPEas ... 4533803433

Andrew Mamohin · #9 Post by **Andrew Mamohin** » 28 Mar 2023, 07:50

Ath wrote: ↑27 Mar 2023, 19:12 https://github.com/letscontrolit/ESPEas ... 4533803433

Everything works without errors. Thank you very much!

TD-er · #10 Post by **TD-er** » 28 Mar 2023, 08:49

Great!

This was a bug in our numerical parser function, so it may also fix other issues where numbers are parsed.

Ath · #11 Post by **Ath** » 31 Mar 2023, 18:48

Andrew Mamohin wrote: ↑28 Mar 2023, 07:50
Ath wrote: ↑27 Mar 2023, 19:12 https://github.com/letscontrolit/ESPEas ... 4533803433
Everything works without errors. Thank you very much!

The fixes have been merged into 'mega'.

on Clock#Time=All,**:00 do

on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Re: on Clock#Time=All,**:00 do

Who is online